| Summary: | [GTK][EFL] Suppress a warning of unused params | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, gyuyoung.kim | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2015-02-11 07:24:30 PST
Created attachment 246390 [details]
Patch
Comment on attachment 246390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246390&action=review > Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:76 > + UNUSED_PARAM(directoryName); Normally in a case like this we would remove the argument name rather than using the UNUSED_PARAM macro. Comment on attachment 246390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246390&action=review >> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:76 >> + UNUSED_PARAM(directoryName); > > Normally in a case like this we would remove the argument name rather than using the UNUSED_PARAM macro. Thanks for your pointing. I'll drop the argument name and land it :) Comment on attachment 246390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246390&action=review >>> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:76 >>> + UNUSED_PARAM(directoryName); >> >> Normally in a case like this we would remove the argument name rather than using the UNUSED_PARAM macro. > > Thanks for your pointing. > I'll drop the argument name and land it :) The name `directoryName` is noted in the header. So we can just drop it. Committed r179932: <http://trac.webkit.org/changeset/179932> |