Bug 141462

Summary: [EFL] Need to have new baseline for some tests of fast/ruby since r172874
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hs85.jeong, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93353    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Gyuyoung Kim 2015-02-10 22:13:31 PST
r172874 modified rendering/RenderRubyRun.cpp. It influenced on EFL port as well. EFL port needs to have new baseline for those tests.


  fast/ruby/bopomofo-letter-spacing.html [ Failure ]
  fast/ruby/bopomofo-rl.html [ Failure ]
  fast/ruby/bopomofo.html [ Failure ]
  fast/ruby/ruby-beforeafter.html [ Failure ]
  fast/ruby/ruby-length.html [ Failure ]
  fast/ruby/ruby-run-break.html [ Failure ]
  fast/ruby/ruby-runs-spans.html [ Failure ]
  fast/ruby/ruby-runs.html [ Failure ]
  fast/ruby/ruby-trailing.html [ Failure ]
  fast/ruby/rubyDOM-insert-rt.html [ Failure ]
  fast/ruby/rubyDOM-insert-text1.html [ Failure ]
  fast/ruby/rubyDOM-insert-text2.html [ Failure ]
  fast/ruby/rubyDOM-insert-text3.html [ Failure ]
  fast/ruby/rubyDOM-remove-rt1.html [ Failure ]
  fast/ruby/rubyDOM-remove-rt2.html [ Failure ]
  fast/ruby/rubyDOM-remove-text1.html [ Failure ]
Comment 1 Hunseop Jeong 2015-02-12 06:42:08 PST
Created attachment 246440 [details]
Patch
Comment 2 Gyuyoung Kim 2015-02-12 07:45:30 PST
You need to do rebase this patch again.
Comment 3 Gyuyoung Kim 2015-02-12 08:28:05 PST
Comment on attachment 246440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246440&action=review

> LayoutTests/ChangeLog:3
> +        Unreviewed, EFL gardening. Rebaseline after r172874

Different bug title with this bug. Below style looks good to me.

[EFL] Need to have new baseline for some tests of fast/ruby since r172874
https://bugs.webkit.org/show_bug.cgi?id=141462

Unreviewed, EFL gardening. Rebaseline after r172874
Comment 4 Hunseop Jeong 2015-02-12 08:58:48 PST
Created attachment 246444 [details]
Patch
Comment 5 Gyuyoung Kim 2015-02-12 09:01:17 PST
Comment on attachment 246444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246444&action=review

> LayoutTests/ChangeLog:8
> +        * platform/efl/TestExpectations:

Missing to update this file.
Comment 6 Hunseop Jeong 2015-02-12 17:19:02 PST
Created attachment 246492 [details]
Patch
Comment 7 WebKit Commit Bot 2015-02-12 18:31:09 PST
Comment on attachment 246492 [details]
Patch

Clearing flags on attachment: 246492

Committed r180027: <http://trac.webkit.org/changeset/180027>
Comment 8 WebKit Commit Bot 2015-02-12 18:31:15 PST
All reviewed patches have been landed.  Closing bug.