Bug 141449

Summary: Clients need the ability to hook into immediate action lifecycle
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebKit2Assignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, conrad_shultz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Conrad Shultz
Reported 2015-02-10 16:58:11 PST
Clients need the ability to hook into immediate action lifecycle
Attachments
Patch (5.10 KB, patch)
2015-02-10 17:15 PST, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Patch (4.11 KB, patch)
2015-02-10 17:41 PST, Conrad Shultz 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-10 16:59:23 PST
<rdar://problem/19790407>
Conrad Shultz
Comment 2 2015-02-10 17:15:08 PST
Created attachment 246352 [details] Patch
Tim Horton
Comment 3 2015-02-10 17:18:29 PST
Comment on attachment 246352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246352&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:183 > + [_wkView _beginImmediateAction]; This is about beginning the animation, not the action. > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:206 > + [_wkView _updateImmediateAction]; Ditto. > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:216 > + [_wkView _cancelImmediateAction]; Ditto. > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:228 > + [_wkView _completeImmediateAction]; This is where the action begins.
Conrad Shultz
Comment 4 2015-02-10 17:28:15 PST
Good point, I'll post a revised version.
Conrad Shultz
Comment 5 2015-02-10 17:41:57 PST
Created attachment 246356 [details] Patch
Conrad Shultz
Comment 6 2015-02-10 18:08:50 PST
Committed r179909: <http://trac.webkit.org/changeset/179909>
Note You need to log in before you can comment on or make changes to this bug.