Bug 141447

Summary:

Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, japhet

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Chris Dumez 2015-02-10 15:15:28 PST

Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange().

The trace seems to hint that frameLoader() returns null when stopLoadingForPolicyChange() is called. frameLoader() can only return null after DocumentLoader::detachFromFrame() has been called.
Also, stopLoadingForPolicyChange() here is called from the DocumentLoader::continueAfterContentPolicy() policy callback which requires m_waitingForContentPolicy to be true. Therefore, we should assert that m_waitingForContentPolicy is false when m_frame is cleared in DocumentLoader::detachFromFrame().

Radar: <rdar://problem/13811738>

Comment 1 Chris Dumez 2015-02-10 15:19:26 PST

Created attachment 246347 [details]
Patch

Comment 2 Chris Dumez 2015-02-10 15:59:10 PST

Committed r179895: <http://trac.webkit.org/changeset/179895>