Bug 141447

Summary: Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, japhet
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Chris Dumez
Reported 2015-02-10 15:15:28 PST
Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange(). The trace seems to hint that frameLoader() returns null when stopLoadingForPolicyChange() is called. frameLoader() can only return null after DocumentLoader::detachFromFrame() has been called. Also, stopLoadingForPolicyChange() here is called from the DocumentLoader::continueAfterContentPolicy() policy callback which requires m_waitingForContentPolicy to be true. Therefore, we should assert that m_waitingForContentPolicy is false when m_frame is cleared in DocumentLoader::detachFromFrame(). Radar: <rdar://problem/13811738>
Attachments
Patch (2.42 KB, patch)
2015-02-10 15:19 PST, Chris Dumez 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-02-10 15:19:26 PST
Created attachment 246347 [details] Patch
Chris Dumez
Comment 2 2015-02-10 15:59:10 PST
Committed r179895: <http://trac.webkit.org/changeset/179895>
Note You need to log in before you can comment on or make changes to this bug.