Bug 141441

Summary:

Add assertion to help track down WebCore::DocumentLoader::stopLoadingForPolicyChange() crash

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, japhet

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Chris Dumez 2015-02-10 12:59:32 PST

Add assertions to help track down WebCore::DocumentLoader::stopLoadingForPolicyChange() crash.

Radar: <rdar://problem/13811738>

Comment 1 Chris Dumez 2015-02-10 13:04:54 PST

Created attachment 246338 [details]
Patch

Comment 2 Alexey Proskuryakov 2015-02-10 13:40:46 PST

Comment on attachment 246338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246338&action=review

> Source/WebCore/ChangeLog:24
> +        (WebCore::DocumentLoader::interruptedForPolicyChangeError):
> +        Make sure frameLoader() is not null before using it.

How does this help? If it's null, we crash right away anyway.

Comment 3 Chris Dumez 2015-02-10 13:44:02 PST

Committed r179880: <http://trac.webkit.org/changeset/179880>