Bug 141430

Summary: iOS needs more WEBCORE_EXPORT macros
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141413    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Alex Christensen
Reported 2015-02-10 06:15:50 PST
I've noted where I'm not sure I should be using WEBCORE_EXPORT macros. Maybe I should use __attribute__((visibility("default"))) directly? Maybe there's a better way to export some of these?
Attachments
Patch (19.66 KB, patch)
2015-02-10 06:33 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (17.88 KB, patch)
2015-02-10 14:43 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-02-10 06:33:17 PST
Created attachment 246321 [details] Patch
Alex Christensen
Comment 2 2015-02-10 14:43:54 PST
Created attachment 246341 [details] Patch
Alex Christensen
Comment 3 2015-02-10 15:08:34 PST
http://trac.webkit.org/changeset/179886
Alex Christensen
Comment 4 2015-02-10 16:20:21 PST
bindings tests fixed in https://trac.webkit.org/r179903 oops
Note You need to log in before you can comment on or make changes to this bug.