Bug 141391

Summary: AX: [Win] OBJID_CLIENT comparisons broken in 64-bit Builds
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: AccessibilityAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+

Brent Fulgham
Reported 2015-02-09 10:20:19 PST
In all builds (64-bit and 32-bit), OBJID_CLIENT is defined as (LONG) 0xFFFFFFFC. However, testing indicates that the lParam value passed to WebKit from the operating system is sometimes passed as 0x0FFFFFFFC, and sometimes as 0xFFFFFFFFFFFFFFFC (depending on client software). This is probably a bug at the client program level (or perhaps even Windows itself), but we can guard against as follows: Instead of checking: lParam != OBJID_CLIENT we can truncate the value: static_cast<LONG>(lParam) != OBJID_CLIENT This will have no effect on our 32-bit builds, and ensure that our 64-bit builds are insulated against this problem.
Attachments
Patch (1.18 KB, patch)
2015-02-09 10:23 PST, Brent Fulgham 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-09 10:20:46 PST
<rdar://problem/19767342>
Brent Fulgham
Comment 2 2015-02-09 10:23:48 PST
Created attachment 246275 [details] Patch
Brent Fulgham
Comment 3 2015-02-09 12:27:52 PST
Committed r179841: <http://trac.webkit.org/changeset/179841>
Note You need to log in before you can comment on or make changes to this bug.