Summary: | [GTK] GMutexLocker build issue | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, cgarcia, chavarria1991, juanj.marin, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2015-02-09 01:07:37 PST
I've got a related problem: In file included from ../../Source/WTF/wtf/gobject/GThreadSafeMainLoopSource.cpp:32:0: ../../Source/WTF/wtf/gobject/GMutexLocker.h:100:12: error: ‘GMutexLocker’ is already declared in this scope using WTF::GMutexLocker; ^ If I comment that line I got the "GMutexLocker is not a template problem" :S Marcos is right. I totally forgot that I had that messsage before and I commented that line. I have the impression this error is related with the addition of GMutexLocker in Glib https://git.gnome.org/browse/glib/commit/?id=1404d3e12819b342fda74d082dcb067a029141b1 So I guess we need to rename ours now :) (In reply to comment #3) > So I guess we need to rename ours now :) As a first step can be a good idea. Ideally, I guess we could remove ours and use GLib's. (In reply to comment #4) > (In reply to comment #3) > > So I guess we need to rename ours now :) > > As a first step can be a good idea. Ideally, I guess we could remove ours > and use GLib's. I don't think so, the glib one is not portable, because it depends on compiler features, ours is C++ 11. Created attachment 246313 [details]
Patch
Committed r179866: <http://trac.webkit.org/changeset/179866> |