Summary: | [iOS] Some MathML tests crash in RenderMathMLOperator::advanceForGlyph() or boundsForGlyph() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dbarton, ddkilzer, dino, esprehn+autocc, fred.wang, glenn, kondapallykalyan, mmaxfield, mrobinson, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2015-02-08 11:52:44 PST
Marked tests as crashing in r179803: <http://trac.webkit.org/changeset/179803> Created attachment 247364 [details]
Patch
Comment on attachment 247364 [details]
Patch
Why doesn't this reproduce on Mac OS X? Is it because the set of fonts is different? Are we missing fonts for iOS?
Why are we passing in GlyphData objects that either have no font or no glyph on iOS?
(In reply to comment #4) > Comment on attachment 247364 [details] > Patch > > Why doesn't this reproduce on Mac OS X? Is it because the set of fonts is > different? Are we missing fonts for iOS? > > Why are we passing in GlyphData objects that either have no font or no glyph > on iOS? iOS doesn't have any fonts that have the glyphs that we are looking for. Afaict, it never did. We are passing in the null items because we directly pass these functions the result of the font lookup code, which might return null. The correct way to deal with this is to check if the looked up font is null before progressing (which is what this patch does). Comment on attachment 247364 [details]
Patch
Thanks for the explanation! r=me (with a Windows build fix)
Created attachment 247556 [details]
Patch
Comment on attachment 247364 [details] Patch Clearing flags on attachment: 247364 Committed r180792: <http://trac.webkit.org/changeset/180792> All reviewed patches have been landed. Closing bug. |