Summary: | DFG should only have two mechanisms for describing effectfulness of nodes; previously there were three | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-02-08 11:00:06 PST
Created attachment 246243 [details]
the patch
Attachment 246243 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGClobberize.h:937: The parameter name "graph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/dfg/DFGClobberize.h:937: The parameter name "node" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/dfg/DFGClobberize.cpp:64: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 246243 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/dfg/DFGClobberize.h:937: The parameter name > "graph" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/dfg/DFGClobberize.h:937: The parameter name > "node" adds no information, so it should be removed. > [readability/parameter_name] [5] Fixed locally. > ERROR: Source/JavaScriptCore/dfg/DFGClobberize.cpp:64: Place brace on its > own line for function definitions. [whitespace/braces] [4] > Total errors found: 3 in 8 files No, that's not our style for lambdas. > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Created attachment 246245 [details]
the patch
Attachment 246245 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGClobberize.cpp:64: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246245 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/179840 |