Bug 141359

Summary:

Use ResourceLoadPriority type in the NetworkCache code

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review-

Description Chris Dumez 2015-02-07 11:10:06 PST

Use ResourceLoadPriority type in the NetworkCache code and rely on ResourceLoadPriorityHighest value instead of hard-coding a new maximumRetrievePriority constant. This seems a bit more robust.

Comment 1 Chris Dumez 2015-02-07 11:11:59 PST

Created attachment 246211 [details]
Patch

Comment 2 Antti Koivisto 2015-02-07 13:32:09 PST

Comment on attachment 246211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246211&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:148
> -    void retrieve(const NetworkCacheKey&, unsigned priority, RetrieveCompletionHandler&&);
> +    void retrieve(const NetworkCacheKey&, WebCore::ResourceLoadPriority, RetrieveCompletionHandler&&);

While in principle a good idea I'm trying establish a layering where the storage layer does not know anything about resources or related concepts. The way to do this cleanly would be to have NetworkCacheStorage::setMaximumPriority (or constructor argument) and call it from the NetworkCache.