| Summary: | Add some dictionary lookup tests | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | ap, bdakin, buildbot, commit-queue, enrica, mitz, rniwa, sam, simon.fraser | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Tim Horton
2015-02-07 02:38:55 PST
Created attachment 246203 [details]
Patch
Created attachment 246204 [details]
Patch
Created attachment 246205 [details]
Patch
Attachment 246205 [details] did not pass style-queue:
ERROR: Source/WebCore/testing/Internals.cpp:1105: Declaration has space between type name and * in NSDictionary *options [whitespace/declaration] [3]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246205 [details] Patch Attachment 246205 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6090105475301376 New failing tests: platform/mac/editing/dictionary-lookup/dictionary-lookup-input.html Created attachment 246206 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 246205 [details] Patch Attachment 246205 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4817938041274368 New failing tests: platform/mac/editing/dictionary-lookup/dictionary-lookup-input.html Created attachment 246207 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Hmm, I guess I better use a fixed-width font and an explicit point size. Or adjust the words so it's harder to vary what you hit. Or figure out how to target just a word like all the other tests... Comment on attachment 246205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246205&action=review Do all these tests need to be separate? Can we combine more than one test in a single HTML/expected pair? dictionary-lookup-input.html seems to be failing on the bot so please don’t land until that’s fixed > Source/WebCore/testing/Internals.cpp:1108 > + ec = INVALID_ACCESS_ERR; UNUSED_PARAM for x and y? > Source/WebCore/testing/Internals.h:165 > + PassRefPtr<Range> rangeForDictionaryLookupAtLocation(long x, long y, ExceptionCode&); Return value should just be RefPtr. Argument types should be int, not long. Confusingly, IDL file “long” corresponds to C++ file “int”. Created attachment 246228 [details]
Patch for EWS
Attachment 246228 [details] did not pass style-queue:
ERROR: Source/WebCore/testing/Internals.cpp:1105: Declaration has space between type name and * in NSDictionary *options [whitespace/declaration] [3]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Forgot to add some annotations. Created attachment 246229 [details]
Patch for EWS
Attachment 246229 [details] did not pass style-queue:
ERROR: Source/WebCore/testing/Internals.cpp:1105: Declaration has space between type name and * in NSDictionary *options [whitespace/declaration] [3]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #10) > Comment on attachment 246205 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246205&action=review > > Do all these tests need to be separate? Can we combine more than one test in > a single HTML/expected pair? I merged a bunch. Not all of them, but into semi-logical chunks. |