Bug 141352

Summary: ASan complains about plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, commit-queue, esprehn+autocc, kangil.han, roger_fong
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Description Alexey Proskuryakov 2015-02-06 23:25:43 PST 
ASan complains about an out of bounds read on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html

rdar://problem/19717490
Comment 1 Alexey Proskuryakov 2015-02-06 23:31:57 PST 
Created attachment 246200 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2015-02-07 11:36:50 PST 
I'm going to assume that the Windows EWS failure is a random flake. The actual error is not visible in the truncated log.
Comment 3 WebKit Commit Bot 2015-02-07 12:21:29 PST 
Comment on attachment 246200 [details]
proposed fix

Clearing flags on attachment: 246200

Committed r179783: <http://trac.webkit.org/changeset/179783>
Comment 4 WebKit Commit Bot 2015-02-07 12:21:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2015-02-07 12:55:46 PST 
Comment on attachment 246200 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246200&action=review

> Source/WebCore/dom/Document.cpp:6274
> +        jsString = String(plugInsJavaScript, sizeof(plugInsJavaScript));

It would be more efficient to call StringImpl::createWithoutCopying here instead of the String constructor. No need to copy the file.
Comment 6 Darin Adler 2015-02-07 12:56:02 PST 
Comment on attachment 246200 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246200&action=review

>> Source/WebCore/dom/Document.cpp:6274
>> +        jsString = String(plugInsJavaScript, sizeof(plugInsJavaScript));
> 
> It would be more efficient to call StringImpl::createWithoutCopying here instead of the String constructor. No need to copy the file.

Copy the characters, I mean.