Bug 141336

Summary:

Ref-ify various getters that return HTMLCollection.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Andreas Kling

Reported 2015-02-06 13:25:00 PST

We have a lot of getters that return non-null RefPtr<HTMLCollection> that should just return Ref<HTMLCollection>.

Attachments
Patch (26.34 KB, patch) 2015-02-06 13:25 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (26.93 KB, patch) 2015-02-06 15:41 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2015-02-06 13:25:29 PST

Created attachment 246177 [details] Patch

WebKit Commit Bot

Comment 2 2015-02-06 13:27:11 PST

Attachment 246177 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLTableSectionElement.cpp:63: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2015-02-06 15:41:43 PST

Created attachment 246183 [details] Patch

WebKit Commit Bot

Comment 4 2015-02-06 17:08:59 PST

Comment on attachment 246183 [details] Patch Clearing flags on attachment: 246183 Committed r179770: <http://trac.webkit.org/changeset/179770>

WebKit Commit Bot

Comment 5 2015-02-06 17:09:03 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.