Bug 141333

Summary: REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, timothy
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2015-02-06 08:53:23 PST
The unit tests are timing out and the inspector doesn't show up in MiniBrowser either. It seems that after r179705 the initial attach message is never received in the UI process.
Comment 1 Brian Burg 2015-02-06 10:05:38 PST
The following code was moved out of the static PageGroup management code. It was re-added in a platform-specific way for PLATFORM(MAC), so maybe it has to be re-added to GTK/EFL when the PageGroup is constructed. (On Mac, Inspector now uses WKWebView which only takes the group identifier. So we first construct the view, then adjust prefs, then do the initial load.)

#ifndef NDEBUG
        // Allow developers to inspect the Web Inspector in debug builds without changing settings.
        pageGroup->preferences().setDeveloperExtrasEnabled(true);
        pageGroup->preferences().setLogsPageMessagesToSystemConsoleEnabled(true);
#endif

        pageGroup->preferences().setAllowFileAccessFromFileURLs(true);
Comment 2 Carlos Garcia Campos 2015-02-08 04:23:02 PST
Yes, that was it, thanks!
Comment 3 Carlos Garcia Campos 2015-02-08 04:23:25 PST
Created attachment 246240 [details]
Patch
Comment 4 Carlos Garcia Campos 2015-02-09 00:02:46 PST
Committed r179821: <http://trac.webkit.org/changeset/179821>