Bug 141327

Summary: REGRESSION(r179476): It broke the !ENABLE(PICTURE_SIZES) build
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, esprehn+autocc, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141026    
Attachments:
Description Flags
Patch ossy: review+

Csaba Osztrogonác
Reported 2015-02-06 02:17:31 PST
../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp: In member function 'void WebCore::TokenPreloadScanner::StartTagScanner::processAttributes(const AttributeList&, WebCore::Document&)': ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp:110:55: error: 'm_sizesAttribute' was not declared in this scope
Attachments
Patch (1.69 KB, patch)
2015-02-11 08:30 PST, Darin Adler 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-11 07:36:56 PST
It seems nobody is interested in fixing this broken ENABLE(PICTURE_SIZES) guard. Can we remove this guard if nobody wants to build with disabled guard?
Darin Adler
Comment 2 2015-02-11 08:30:25 PST
Created attachment 246393 [details] Patch
Darin Adler
Comment 3 2015-02-11 08:41:14 PST
Committed r179928: <http://trac.webkit.org/changeset/179928>
Note You need to log in before you can comment on or make changes to this bug.