Bug 141326

Summary: error: redefinition of 'tryGetFileBackedSharedBufferFromCFURLCachedResponse in OSX 10.8.5
Product: WebKit Reporter: Hyungwook Lee <hyungwook.lee>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.8   
Attachments:
Description Flags
patch ap: review-

Description Hyungwook Lee 2015-02-06 00:23:25 PST
I've compilation errors on OSX 10.8.5 as follows.

webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:49:44: error: redefinition of 'tryGetFileBackedSharedBufferFromCFURLCachedResponse'
PassRefPtr<SharedBuffer> DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse(CFCachedURLResponseRef cachedResponse)
                                           ^
In file included from webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:27:
webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:64:51: note: previous definition is here
inline PassRefPtr<SharedBuffer> DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse(CFCachedURLResponseRef)
                                                  ^
webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:58:24: error: redefinition of 'monitorFileBackingStoreCreation'
void DiskCacheMonitor::monitorFileBackingStoreCreation(const ResourceRequest& request, SessionID sessionID, CFCachedURLResponseRef cachedResponse)
                       ^
In file included from webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:27:
webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:60:31: note: previous definition is here
inline void DiskCacheMonitor::monitorFileBackingStoreCreation(const ResourceRequest&, SessionID, CFCachedURLResponseRef)
Comment 1 Hyungwook Lee 2015-02-06 00:32:55 PST
Created attachment 246153 [details]
patch
Comment 2 Alexey Proskuryakov 2015-02-06 23:01:40 PST
Comment on attachment 246153 [details]
patch

Support for OS X 10.8 has been removed from WebKit trunk. I think that even with this fix, you will find out that a lot of things don't work correctly.