Bug 141313

Summary: [iOS] Run a full garbage collection on memory warning.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, kling, webkit-bug-importer
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2015-02-05 16:17:08 PST
In the iOS/WebKit1 world, we would synchronously GC upon receiving a memory warning. We should have the same behavior in iOS/WebKit2.
Attachments
Patch (1.52 KB, patch)
2015-02-05 17:48 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2015-02-05 18:40 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-05 16:18:09 PST
<rdar://problem/19738024>
Andreas Kling
Comment 2 2015-02-05 17:48:00 PST
Created attachment 246142 [details] Patch
Chris Dumez
Comment 3 2015-02-05 18:09:46 PST
Comment on attachment 246142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246142&action=review > Source/WebCore/platform/MemoryPressureHandler.cpp:139 > +#if PLATFORM(IOS) Since this is iOS-specific, it seems like this should be in MemoryPressureHandler::platformReleaseMemory(bool) in MemoryPressureHandlerCocoa.mm, right?
Andreas Kling
Comment 4 2015-02-05 18:40:23 PST
Created attachment 246143 [details] Patch Moved the logic per Chris's excellent suggestion.
Chris Dumez
Comment 5 2015-02-05 18:41:49 PST
Comment on attachment 246143 [details] Patch r=me
Andreas Kling
Comment 6 2015-02-05 19:14:25 PST
Comment on attachment 246143 [details] Patch Clearing flags on attachment: 246143 Committed r179737: <http://trac.webkit.org/changeset/179737>
Andreas Kling
Comment 7 2015-02-05 19:14:30 PST
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 8 2015-02-12 15:19:48 PST
I'm worried about cost here in the edge case of pathological pressure. Let's do what you suggested in person -- GC now in response to background, GC soon in response to memory warning.
Note You need to log in before you can comment on or make changes to this bug.