Summary: | Shell scripts to build WebKit should be forced to LF endings | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED WONTFIX | ||||||||||
Severity: | Normal | CC: | ap, ddkilzer, mrowe | ||||||||
Priority: | P2 | ||||||||||
Version: | 523.x (Safari 3) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Peter Kasting
2007-06-13 14:29:27 PDT
At least these files seem to also need changing to LF endings as well: WebKit\WebCore\css\CSSPropertyNames.in WebKit\WebCore\css\CSSValueKeywords.in WebKit\WebCore\ksvg2\css\CSSPropertyNames.in WebKit\WebCore\ksvg2\css\CSSValueKeywords.in (In reply to comment #0) > I tried to write a patch to do this, but got errors from svn-create-patch :(. > So someone with commit access will have to handle this one. Please file another Bugzilla bug for this issue, with steps to reproduce and any error output you saw. It should be put in the "Tools / Tests" component. Thanks! Created attachment 16428 [details]
Trim EOL code
I'm using cygwin with CR-LF endings.
Build failed at first due to that EOL code issue. So I made changes show in the patch.
After this change, build succeeded and produced code works well.
This patch does nothing when run with LF endings so won't balk build process on Mac.
Comment on attachment 16428 [details] Trim EOL code Needs a ChangeLog: http://webkit.org/coding/contributing.html Also, please set the "review?" flag to make sure this gets reviewed. Thanks for the patch! Created attachment 16432 [details]
Patch v2
Sorry..
Here's a new patch including ChangeLog.
Comment on attachment 16432 [details] Patch v2 >@@ -68,6 +68,8 @@ while (<IN>) { > chomp; > my $prop = $_; > >+ $prop =~ s/[\r\n]+$//; The chomp statement isn't necessary with the added line. (Sorry, I should have caught this with the first review.) Please remove the chomp statement, repost the patch, and r=me. Created attachment 16463 [details]
Patch v3
Thanks, here's a new patch.
Removed chomp statement and replaced with that regexp.
Comment on attachment 16463 [details]
Patch v3
r=me
The script being patched no longer exists on trunk, so this patch is not needed. |