Bug 141255 – test-webkitpy fails on Mac without iphoneos SDK

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

We should support running the Python unit tests on a Mac without the iphoneos SDK.

[Daniel Bates]

<rdar://problem/19619691>

[Daniel Bates]

Created attachment 246041 [details]
Patch and unit test

As mentioned in the ChangeLog entry for PlatformInfo.xcode_sdk_version(), I took advantage of the behavior that xcrun --show-sdk-version only writes to standard output if the SDK is installed to return the empty string when the SDK is not installed. Let me know if it is preferred to explicitly check the exit status of xcrun and return the empty string instead of making use of this behavior.

[David Kilzer (:ddkilzer)]

Comment on attachment 246041 [details]
Patch and unit test

r=me

[Alexey Proskuryakov]

Comment on attachment 246041 [details]
Patch and unit test

View in context: https://bugs.webkit.org/attachment.cgi?id=246041&action=review

> Tools/Scripts/webkitpy/port/ios.py:57
> +                raise Exception("Ensure that the Xcode command line tools and the iphoneos SDK are installed.")

Maybe add a "please" somewhere here? E.g. "Please install Xcode command line tools and the iPhone SDK".

Also, why do we need command line tools? I thought that we didn't rely on them.

[Daniel Bates]

(In reply to comment #4)
> Comment on attachment 246041 [details]
> Patch and unit test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246041&action=review
> 
> > Tools/Scripts/webkitpy/port/ios.py:57
> > +                raise Exception("Ensure that the Xcode command line tools and the iphoneos SDK are installed.")
> 
> Maybe add a "please" somewhere here? E.g. "Please install Xcode command line
> tools and the iPhone SDK".
> 
> Also, why do we need command line tools? I thought that we didn't rely on
> them.

After talking with Alexey Proskuryakov on IRC today (02/04) we confirmed that xcrun is included with a default OS install. So, I will update the exception message to read: "Please install the iOS SDK."

[Daniel Bates]

Committed r179622: <http://trac.webkit.org/changeset/179622>

[Daniel Bates]

Fixed exception message per comment 5 and committed this in <http://trac.webkit.org/changeset/179629>.