Bug 141251

Summary:

Make sure CachedFont clients do not override both fontLoaded and notifyFinished

Product:

WebKit

Reporter:

Julien Isorce <j.isorce>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

beidson, commit-queue, japhet, mmaxfield, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
CachedFont: ensure clients overrides fontLoaded instead of notifyFinished.	beidson: review-

Description Julien Isorce 2015-02-04 08:32:59 PST

Similar to what have been done for CachedImage clients: https://bugs.webkit.org/show_bug.cgi?id=140722 

With CachedFont all clients already only implement fontLoaded but lets make sure the situation remains simple in the future.

Patch coming soon.

Comment 1 Julien Isorce 2015-02-04 08:40:46 PST

Created attachment 246034 [details]
CachedFont: ensure clients overrides fontLoaded instead of notifyFinished.

Comment 2 Brady Eidson 2017-04-24 19:05:16 PDT

Comment on attachment 246034 [details]
CachedFont: ensure clients overrides fontLoaded instead of notifyFinished.

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.

Comment 3 Myles C. Maxfield 2017-04-25 15:29:13 PDT

Yeah, the implementation of this has completely changed. This bug is now irrelevant.