Bug 141251

Summary: Make sure CachedFont clients do not override both fontLoaded and notifyFinished
Product: WebKit Reporter: Julien Isorce <j.isorce>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: beidson, commit-queue, japhet, mmaxfield, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. beidson: review-

Julien Isorce
Reported 2015-02-04 08:32:59 PST
Similar to what have been done for CachedImage clients: https://bugs.webkit.org/show_bug.cgi?id=140722 With CachedFont all clients already only implement fontLoaded but lets make sure the situation remains simple in the future. Patch coming soon.
Attachments
CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. (2.20 KB, patch)
2015-02-04 08:40 PST, Julien Isorce 		beidson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Isorce
Comment 1 2015-02-04 08:40:46 PST
Created attachment 246034 [details] CachedFont: ensure clients overrides fontLoaded instead of notifyFinished.
Brady Eidson
Comment 2 2017-04-24 19:05:16 PDT
Comment on attachment 246034 [details] CachedFont: ensure clients overrides fontLoaded instead of notifyFinished. This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Myles C. Maxfield
Comment 3 2017-04-25 15:29:13 PDT
Yeah, the implementation of this has completely changed. This bug is now irrelevant.
Note You need to log in before you can comment on or make changes to this bug.