| Summary: | Remove Mountain Lion specific test expectations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, darin, ossy, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Csaba Osztrogonác
2015-02-04 03:30:12 PST
Created attachment 246025 [details]
Patch
removing platform/mac-mountainlion isn't included, because it is too big for bugzilla.
Maybe some expected files should be copied to platfomr/win, because Windows platform still falls back to the non-existent Mountain Lion platform. "Baseline search path: win -> mac-mountainlion -> mac -> generic" Or maybe all expected.txt should be moved from mac-mountainlion to win, which isn't exist in win directory. One more question: Does win platform use [ MountainLion ] modifiers in mac/TestExpectation file too? (In reply to comment #3) > "Baseline search path: win -> mac-mountainlion -> mac -> generic" We should move the mac-mountainlion "-expected" stuff over to win (unless win already has its own version). Many of these are actually not right for Windows, and I've been rebaselining and cleaning things up over the past few weeks. > Or maybe all expected.txt should be moved from mac-mountainlion > to win, which isn't exist in win directory. Yes, we probably should unless win/TestExpectations already has its own markup for that file. > One more question: Does win platform use [ MountainLion ] > modifiers in mac/TestExpectation file too? I'm actually not sure! I suspect that it does, because its coded as a mountain-lion variant. I propose the following: 1. Move unique mac-mountainlion test expectations to win (unless conflicting with existing win). 2. Move mac MountainLion stuff from mac/TestExpectations to win/TestExpectations (unless conflicting) and remove the [ MountainLion ] guard. Once that's done, I'll take another pass over the Windows tests and rebaseline or clean up as necessary. Don't worry about making the Windows test bots red during these changes. They are very much a work in progress, but I'm getting them closer to green every day! :-) I checked webkitpy, fortunately win doesn't use mac or mac*/TestExpectations files, so it's safe to land the test expectations cleanup now. And we can do the expected file migration in separated patch(es) later. Created attachment 246040 [details]
Patch
Comment on attachment 246040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246040&action=review > LayoutTests/platform/mac/TestExpectations:1213 > # Probably the same issue as above, but noticed earlier This comment refers to one above that you deleted. Committed r179684: <http://trac.webkit.org/changeset/179684> |