Bug 141223

Summary: [iOS WK2] Assert in ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren() on tab switching
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
EWS testing
none
More EWSing simon.fraser: review+

Description Simon Fraser (smfr) 2015-02-03 17:24:00 PST
[iOS WK2] Assert in ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren() on tab switching
Comment 1 Simon Fraser (smfr) 2015-02-03 17:30:38 PST
Created attachment 245995 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-02-03 17:31:24 PST
This patch will almost certainly break on non-Apple platforms. Will fix before submitting.
Comment 3 Simon Fraser (smfr) 2015-02-03 17:31:47 PST
rdar://problem/18458993
Comment 4 Tim Horton 2015-02-03 18:07:41 PST
Comment on attachment 245995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245995&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:198
> +    enum class LayerType {

should this just be "Type"? So that its name is WebCore::GraphicsLayer::Type instead of WebCore::GraphicsLayer::LayerType?

> Source/WebCore/platform/graphics/GraphicsLayer.h:317
> +    

no.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3183
>      // move over animations

Get rid of this comment?
Comment 5 Simon Fraser (smfr) 2015-02-03 20:15:42 PST
Created attachment 246010 [details]
EWS testing
Comment 6 Simon Fraser (smfr) 2015-02-03 22:57:02 PST
Created attachment 246020 [details]
More EWSing
Comment 7 Simon Fraser (smfr) 2015-02-04 09:14:12 PST
Comment on attachment 246020 [details]
More EWSing

Carrying Tim's r+ forward
Comment 8 Simon Fraser (smfr) 2015-02-04 09:15:24 PST
https://trac.webkit.org/r179604