Bug 141172

Summary:

run-perf-tests: allow to specify a wrapper command.

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+, rniwa: commit-queue-

Carlos Alberto Lopez Perez

Reported 2015-02-02 14:28:52 PST

run-webkit-tests allows to specify a wrapper command for debugging purposes. $ Tools/Scripts/run-webkit-tests --help|grep -i wrappe -A1 --wrapper=WRAPPER wrapper command to insert before invocations of DumpRenderTree; option is split on whitespace before running. (Example: --wrapper='valgrind --smc- check=all') run-perf-tests should allow the same.

Attachments
Patch (2.79 KB, patch) 2015-02-02 14:44 PST, Carlos Alberto Lopez Perez	rniwa: review+ rniwa: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2015-02-02 14:44:21 PST

Created attachment 245903 [details] Patch

Ryosuke Niwa

Comment 2 2015-02-02 22:43:42 PST

Comment on attachment 245903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245903&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:226 > + "DumpRenderTree or WTR; option is split on whitespace before " Please spell out WebKitTestRunner. > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:137 > + "DumpRenderTree or WTR; option is split on whitespace before " Ditto.

Carlos Alberto Lopez Perez

Comment 3 2015-02-03 10:21:20 PST

Committed r179553: <http://trac.webkit.org/changeset/179553>

Note You need to log in before you can comment on or make changes to this bug.