Bug 141172

Summary: run-perf-tests: allow to specify a wrapper command.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+, rniwa: commit-queue-

Description Carlos Alberto Lopez Perez 2015-02-02 14:28:52 PST
run-webkit-tests allows to specify a wrapper command for debugging purposes.

$ Tools/Scripts/run-webkit-tests --help|grep -i wrappe -A1
    --wrapper=WRAPPER   wrapper command to insert before invocations of
                        DumpRenderTree; option is split on whitespace before
                        running. (Example: --wrapper='valgrind --smc-
                        check=all')



run-perf-tests should allow the same.
Comment 1 Carlos Alberto Lopez Perez 2015-02-02 14:44:21 PST
Created attachment 245903 [details]
Patch
Comment 2 Ryosuke Niwa 2015-02-02 22:43:42 PST
Comment on attachment 245903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245903&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:226
> +                 "DumpRenderTree or WTR; option is split on whitespace before "

Please spell out WebKitTestRunner.

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:137
> +                 "DumpRenderTree or WTR; option is split on whitespace before "

Ditto.
Comment 3 Carlos Alberto Lopez Perez 2015-02-03 10:21:20 PST
Committed r179553: <http://trac.webkit.org/changeset/179553>