Bug 141156 – W3C test importer should sort the list of files when generating the w3c-import.log

• Component: Tools / Tests
• Status: RESOLVED FIXED

[youenn fablet]

Sorting the list of files allows better diff of the w3c-import.log when reimporting a folder

[youenn fablet]

Created attachment 245870 [details]
Patch

[youenn fablet]

Having the import time in the log is also making diff big when reimporting several folders. Can we remove the import time from the log, given we have version control?

More generally, I wonder whether w3c-import.log is all that useful.

[Bem Jones-Bey]

Comment on attachment 245870 [details]
Patch

Makes sense. r=me

[Bem Jones-Bey]

(In reply to comment #2)
> Having the import time in the log is also making diff big when reimporting
> several folders. Can we remove the import time from the log, given we have
> version control?

Yeah, I think that's a good point. Feel free to remove it in this patch before landing, if you like.

> 
> More generally, I wonder whether w3c-import.log is all that useful.

I think it's useful when doing manual piecemeal imports. If we get to the point where we're always doing imports into a standard place of the entire repo, I'd say it'd be a lot less useful.

[youenn fablet]

Created attachment 245953 [details]
Removing import time logging

[WebKit Commit Bot]

Comment on attachment 245953 [details]
Removing import time logging

Rejecting attachment 245953 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 245953 [details]
Removing import time logging

Rejecting attachment 245953 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 245953, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
-tests/tools/scripts/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/tools/sslutils/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/tools/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/tools/webdriver/webdriver/w3c-import.log
patching file LayoutTests/imported/w3c/web-platform-tests/w3c-import.log

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5451763813449728

[youenn fablet]

Created attachment 246044 [details]
Patch to land

[WebKit Commit Bot]

Comment on attachment 246044 [details]
Patch to land

Clearing flags on attachment: 246044

Committed r179628: <http://trac.webkit.org/changeset/179628>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.