Bug 141151 – imported/w3c/web-platform-tests should contain top level files of the W3C web-platform-tests repository

• Component: Tools / Tests
• Status: RESOLVED FIXED

[youenn fablet]

Top level files include help information which may be useful, as well as the W3C license, which may be needed (?).
The missing files are currently CONTRIBUTING.md, LICENSE and README.md

[youenn fablet]

Created attachment 245865 [details]
Patch

[youenn fablet]

(In reply to comment #1)
> Created attachment 245865 [details]
> Patch

Patch adds README.md and server-side.md which are useful information.
It also adds LICENSE which may be needed.
It also adds CONTRIBUTING.md which may not be relevant.
But it is worth deciding what we should add/not add.

[Bem Jones-Bey]

Other than the LICENSE file, I'm not convinced there is utility in having these files in the webkit repo. They all talk about things you need to do to add new WPT tests, but since everyone should be doing that upstream and not in WebKit, they'd have to grab the WPT repo and read the docs there anyways.

[youenn fablet]

(In reply to comment #3)
> Other than the LICENSE file, I'm not convinced there is utility in having
> these files in the webkit repo. They all talk about things you need to do to
> add new WPT tests, but since everyone should be doing that upstream and not
> in WebKit, they'd have to grab the WPT repo and read the docs there anyways.

When debuggging tests, I found useful some information inside server-side.md.
The README.md contains the list of domains that should be defined. That is not yet supported by webkit infrastructure and may explain why some bugs fail.
The CONTRIBUTING.md contains information somehow more precise than what we put in the w3c-import.log files.
Not to say that these files are crucial though, except maybe for LICENSE.

Checking blink and mozilla, they both include LICENSE, README.md and CONTRIBUTING.md.

[Ryosuke Niwa]

Comment on attachment 245865 [details]
Patch

rs=me.

It seems fine to have these files.

[WebKit Commit Bot]

Comment on attachment 245865 [details]
Patch

Clearing flags on attachment: 245865

Committed r179542: <http://trac.webkit.org/changeset/179542>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.