Bug 141125 – Ambiguous naming: Do not call replacedContentRect()'s return value paint rect.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

It's the content rect.

[alan]

Created attachment 245802 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 245802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245802&action=review

> Source/WebCore/rendering/RenderHTMLCanvas.cpp:73
> +    LayoutRect contentBoxRect = this->contentBoxRect();
> +    contentBoxRect.moveBy(paintOffset);
> +    LayoutRect contentRect = replacedContentRect(intrinsicSize());

I'm not sure "contentBoxRect" vs "contentRect" is much clearer.

Maybe "contentRect" could be "imageDestinationRect"?

[alan]

(In reply to comment #2)
> Comment on attachment 245802 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245802&action=review
> 
> > Source/WebCore/rendering/RenderHTMLCanvas.cpp:73
> > +    LayoutRect contentBoxRect = this->contentBoxRect();
> > +    contentBoxRect.moveBy(paintOffset);
> > +    LayoutRect contentRect = replacedContentRect(intrinsicSize());
> 
> I'm not sure "contentBoxRect" vs "contentRect" is much clearer.
> 
> Maybe "contentRect" could be "imageDestinationRect"?
Ok, but imageDestinationRect sounds too specific. This is a replaced element term where the content box rect is extended/shrunk/fit based on the object-fit property value. How about we just call it "replacedContentRect"?

[alan]

Created attachment 245889 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 245889 [details]
Patch

Clearing flags on attachment: 245889

Committed r179488: <http://trac.webkit.org/changeset/179488>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.