Bug 141112

Summary:

REGRESSION (r177689): Emoji variation sequences rendered incorrectly (as characters from other non-emoji font)

Product:

WebKit

Reporter:

mitz

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, mmaxfield

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description mitz 2015-01-31 00:50:31 PST

<rdar://problem/19656263>

For example, ♥️ (BLACK HEART SUIT + VS16) looks like “î G”.

This was caused by a mistake in <http://trac.webkit.org/r177689>, the fix for bug 138683: in ComplexTextController::collectComplexTextRunsForCharacters(), the test
	if (CFEqual(cgFont.get(), runCGFont.get()))
was replaced with a tautology
	if (CFEqual(runFontEqualityObject.get(), runFontEqualityObject.get())) 

This is easy to fix by removing the (re)definition of runFontEqualityObject inside the for loop and checking
	if (CFEqual(runFont->platformData().objectForEqualityCheck().get(), runFontEqualityObject.get()))

Comment 1 Myles C. Maxfield 2015-01-31 14:31:36 PST

Whoops :(

Comment 2 Myles C. Maxfield 2015-01-31 16:46:20 PST

Created attachment 245806 [details]
Patch

Comment 3 WebKit Commit Bot 2015-01-31 20:17:56 PST

Comment on attachment 245806 [details]
Patch

Clearing flags on attachment: 245806

Committed r179459: <http://trac.webkit.org/changeset/179459>

Comment 4 WebKit Commit Bot 2015-01-31 20:17:59 PST

All reviewed patches have been landed.  Closing bug.