Bug 141110

Summary:

Use simpler CachedResourceMap structure in MemoryCache with CACHE_PARTITIONING enabled

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, japhet, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=231117

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2015-01-30 22:45:51 PST

Use simpler CachedResourceMap structure in Memory with CACHE_PARTITIONING enabled. Previously, we would be using a HashMap of HashMap to store CachedResources. The outer HashMap would use the URL as key and the inner HashMap using the partition name as key. This would make traversing the structure overly complicated, especially considering that the code needs to traverse a simple HashMap if CACHE_PARTITIONING is disabled. This patch updates the CachedResourceMap structure to be a simple HashMap, whose key is an std::pair<URL, String /* partitionName */>. Having a flat structure simplifies the traversal code a lot and enables more code sharing between CACHE_PARTITIONING and !CACHE_PARTITIONING. This shouldn't regress performance because we already have both a URL and a partition name when we need to look up a resource. We never need to retrieve all resources with a particular URL.

Attachments
Patch (14.56 KB, patch) 2015-01-30 22:52 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (14.95 KB, patch) 2015-01-31 13:17 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (14.95 KB, patch) 2015-01-31 13:18 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.