Summary: | Web Inspector: console.table with columnName filter for non-existent property should still show column | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-01-29 18:56:41 PST
Created attachment 245993 [details]
[IMAGE] Proposed Changes
Created attachment 245994 [details]
[PATCH] Proposed Fix
It kinda stinks that we pass this array to the frontend as a RemoteObject. This forces the frontend to peek into the preview to get string values. This could be an optional property on ConsoleMessage, but I felt it might make sense keeping it a "console.table" parameter like a "console.log" parameter. I can go with either approach.
Comment on attachment 245994 [details] [PATCH] Proposed Fix Clearing flags on attachment: 245994 Committed r179635: <http://trac.webkit.org/changeset/179635> All reviewed patches have been landed. Closing bug. |