Bug 141063

Summary: JSON.stringify on ClientRect returns an empty object.
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Matthew Mirman <mmirman>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, ggaren, mark.lam, mmirman, oliver, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Added a ClientRect as an interface that requires attributes on instance
oliver: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Added a ClientRect as an interface that requires attributes on instance
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Added a ClientRect as an interface that requires attributes on instance none

Description Matthew Mirman 2015-01-29 17:40:35 PST
rdar://problem/18437653

Patch forthcoming.
Comment 1 Matthew Mirman 2015-01-29 17:56:07 PST
Created attachment 245679 [details]
Added a ClientRect as an interface that requires attributes on instance
Comment 2 Build Bot 2015-01-29 18:35:27 PST
Comment on attachment 245679 [details]
Added a ClientRect as an interface that requires attributes on instance

Attachment 245679 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5461305083297792

New failing tests:
js/dom/JSON-stringify.html
Comment 3 Build Bot 2015-01-29 18:35:30 PST
Created attachment 245680 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-01-29 18:48:38 PST
Comment on attachment 245679 [details]
Added a ClientRect as an interface that requires attributes on instance

Attachment 245679 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5121898513956864

New failing tests:
js/dom/JSON-stringify.html
Comment 5 Build Bot 2015-01-29 18:48:42 PST
Created attachment 245681 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Matthew Mirman 2015-01-29 19:21:40 PST
Created attachment 245684 [details]
Added a ClientRect as an interface that requires attributes on instance

Updated expected results.
Comment 7 Build Bot 2015-01-29 20:13:14 PST
Comment on attachment 245684 [details]
Added a ClientRect as an interface that requires attributes on instance

Attachment 245684 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5825585955733504

New failing tests:
js/dom/JSON-stringify.html
Comment 8 Build Bot 2015-01-29 20:13:16 PST
Created attachment 245685 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 9 Build Bot 2015-01-29 20:21:43 PST
Comment on attachment 245684 [details]
Added a ClientRect as an interface that requires attributes on instance

Attachment 245684 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4567062827499520

New failing tests:
js/dom/JSON-stringify.html
Comment 10 Build Bot 2015-01-29 20:21:47 PST
Created attachment 245688 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 11 Matthew Mirman 2015-01-30 10:32:12 PST
Created attachment 245726 [details]
Added a ClientRect as an interface that requires attributes on instance

Fixed expectations again.
Comment 12 Matthew Mirman 2015-01-30 11:11:02 PST
Patch landed: http://trac.webkit.org/changeset/179406  

Closing bug.
Comment 13 Geoffrey Garen 2015-01-30 12:23:56 PST
So, does JSON.stringify only work for "own" properties?
Comment 14 Matthew Mirman 2015-01-30 13:05:01 PST
(In reply to comment #13)
> So, does JSON.stringify only work for "own" properties?

Yes. This appears to be the standard accepted behavior.