| Summary: | Remove more Mountain Lion code from WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, ap, bdakin, mitz, sam, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Beth Dakin
2015-01-29 14:56:37 PST
Created attachment 245655 [details]
Patch
Comment on attachment 245655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245655&action=review > Source/WebKit2/config.h:-73 > -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 Shouldn't this still be in a PLATFORM(MAC)? > Source/WebKit2/Shared/WebPreferencesDefinitions.h:-41 > -#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090) Sam conflicted with you here. > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:-173 > -#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 swap this to PLATFORM(MAC)? (In reply to comment #2) > Comment on attachment 245655 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245655&action=review > > > Source/WebKit2/config.h:-73 > > -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 > > Shouldn't this still be in a PLATFORM(MAC)? > YES! Good catch. > > Source/WebKit2/Shared/WebPreferencesDefinitions.h:-41 > > -#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090) > > Sam conflicted with you here. > Resolved now. > > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:-173 > > -#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 > > swap this to PLATFORM(MAC)? Sure. As we discussed on IRC, there are a lot of these, and they suck. But sure, I will fix this one. http://trac.webkit.org/changeset/179373 |