Bug 141049

Summary: Call WebPage::didChangeSelection() asynchronously
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-mavericks-wk2 none

Chris Dumez
Reported 2015-01-29 14:23:58 PST
Call WebPage::didChangeSelection() asynchronously to avoid sending a lot of IPC within a single event loop iteration and retrieving the editorState() each time (which is expensive).
Attachments
WIP patch (1.90 KB, patch)
2015-01-29 14:24 PST, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (696.10 KB, application/zip)
2015-01-29 15:17 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-29 14:24:50 PST
Created attachment 245648 [details] WIP patch
Build Bot
Comment 2 2015-01-29 15:17:51 PST
Comment on attachment 245648 [details] WIP patch Attachment 245648 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5022045893033984 New failing tests: platform/mac/editing/input/selection-change-closes-typing.html platform/mac/editing/input/selection-change-closes-typing-2.html editing/secure-input/removed-password-input.html editing/secure-input/reset-state-on-navigation.html editing/secure-input/password-input-focusing.html editing/secure-input/password-input-changed-type.html
Build Bot
Comment 3 2015-01-29 15:17:53 PST
Created attachment 245660 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Alexey Proskuryakov
Comment 4 2015-01-29 20:27:58 PST
A change like thug would be very hard to make. Probably impossible on Mavericks with its synchronous NSTextInputClient. We have very little test coverage for interactive text input.
Chris Dumez
Comment 5 2015-01-29 20:29:43 PST
(In reply to comment #4) > A change like thug would be very hard to make. Probably impossible on > Mavericks with its synchronous NSTextInputClient. > > We have very little test coverage for interactive text input. Agreed. This was just a test to get results from EWS. I will indeed have to go in another direction.
Note You need to log in before you can comment on or make changes to this bug.