Bug 141048

Summary: Removed op_ret_object_or_this
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
msaboff: review+
performance test results none

Description Geoffrey Garen 2015-01-29 14:05:33 PST 
Removed op_ret_object_or_this
Comment 1 Geoffrey Garen 2015-01-29 14:09:10 PST 
Created attachment 245646 [details]
Patch
Comment 2 Ryosuke Niwa 2015-01-29 14:13:37 PST 
Comment on attachment 245646 [details]
Patch

Please run the benchmarks before landing this.
Comment 3 Geoffrey Garen 2015-01-29 14:42:35 PST 
Created attachment 245651 [details]
Patch
Comment 4 Geoffrey Garen 2015-01-29 14:43:27 PST 
Caught a bug: You need to test is_object and is_function since is_object only tests "typeof x == 'object'", which doesn't cover functions.
Comment 5 Michael Saboff 2015-01-29 15:03:47 PST 
Comment on attachment 245651 [details]
Patch

r=me
Comment 6 Geoffrey Garen 2015-01-29 15:15:32 PST 
Created attachment 245659 [details]
performance test results

I'd call this neutral. The fluctuating speedups and slowdowns don't hit this code path.
Comment 7 Geoffrey Garen 2015-01-29 15:17:14 PST 
Committed r179372: <http://trac.webkit.org/changeset/179372>