Bug 141048

Summary: Removed op_ret_object_or_this
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
msaboff: review+
performance test results none

Geoffrey Garen
Reported 2015-01-29 14:05:33 PST
Removed op_ret_object_or_this
Attachments
Patch (10.80 KB, patch)
2015-01-29 14:09 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (11.15 KB, patch)
2015-01-29 14:42 PST, Geoffrey Garen 		msaboff: review+
DetailsFormatted DiffDiff
performance test results (50.34 KB, text/plain)
2015-01-29 15:15 PST, Geoffrey Garen 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2015-01-29 14:09:10 PST
Created attachment 245646 [details] Patch
Ryosuke Niwa
Comment 2 2015-01-29 14:13:37 PST
Comment on attachment 245646 [details] Patch Please run the benchmarks before landing this.
Geoffrey Garen
Comment 3 2015-01-29 14:42:35 PST
Created attachment 245651 [details] Patch
Geoffrey Garen
Comment 4 2015-01-29 14:43:27 PST
Caught a bug: You need to test is_object and is_function since is_object only tests "typeof x == 'object'", which doesn't cover functions.
Michael Saboff
Comment 5 2015-01-29 15:03:47 PST
Comment on attachment 245651 [details] Patch r=me
Geoffrey Garen
Comment 6 2015-01-29 15:15:32 PST
Created attachment 245659 [details] performance test results I'd call this neutral. The fluctuating speedups and slowdowns don't hit this code path.
Geoffrey Garen
Comment 7 2015-01-29 15:17:14 PST
Committed r179372: <http://trac.webkit.org/changeset/179372>
Note You need to log in before you can comment on or make changes to this bug.