|Summary:||Crash in JSC::DFG::StackLayoutPhase::run|
|Product:||WebKit||Reporter:||Han Choongwoo <cwhan.tunz>|
|Severity:||Critical||CC:||fpizlo, ggaren, mark.lam, msaboff, oliver, ossy, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description Han Choongwoo 2015-01-29 01:38:12 PST
Comment 4 Filip Pizlo 2015-04-08 14:20:06 PDT
Comment on attachment 245915 [details] Patch We removed this usesArguments() stuff.
Comment 5 Geoffrey Garen 2015-04-08 15:05:25 PDT
Comment on attachment 245915 [details] Patch Should we still take these additional regression tests, since they presumably cover something that was not covered before?
Comment 6 Filip Pizlo 2015-04-08 15:10:09 PDT
(In reply to comment #5) > Comment on attachment 245915 [details] > Patch > > Should we still take these additional regression tests, since they > presumably cover something that was not covered before? Nah. Previously, if you said "arguments" then the whole compiler - every compiler in every tier - would flip into this alternate reality world. So we were steadily converging towards having two versions of every test: one that said "arguments" and one that didn't. This isn't true anymore. Saying "arguments" only changes how the arguments themselves are accessed but after bytecode generation, none of the tiers really care. So, having tests for recursion using apply where you say "arguments" isn't really useful. There's nothing special about that anymore.