Bug 141010

Summary:

Remove Mountain Lion code from WebKit and WebKit2

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, bdakin, mitz, sam, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Beth Dakin

Reported 2015-01-28 13:59:57 PST

Remove Mountain Lion code from WebKit and WebKit2

Attachments
Patch (14.16 KB, patch) 2015-01-28 14:02 PST, Beth Dakin	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2015-01-28 14:02:01 PST

Created attachment 245571 [details] Patch

Sam Weinig

Comment 2 2015-01-28 14:19:08 PST

Comment on attachment 245571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245571&action=review > Source/WebKit2/WebKit2Prefix.h:-60 > -#define WTF_USE_XPC_SERVICES 1 You got this one backwards, we still need WTF_USE_XPC_SERVICES defined to 1. That said, you could actually get rid of this, and just find the one or two users of USE(XPC_SERVICES) and remove them since it should always be true now. > Source/WebKit2/UIProcess/API/mac/WKView.mm:-4003 > NSRect contentRect = [[NSScreen mainScreen] frame]; > -#endif I would get rid of the variable and just do this on the next line. > Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:282 > I would get rid of this blank line.

Beth Dakin

Comment 3 2015-01-28 14:22:45 PST

Thanks Sam! I fixed the things you found. http://trac.webkit.org/changeset/179294

Note You need to log in before you can comment on or make changes to this bug.