| Summary: | Add API::{FrameInfo, NavigationAction, NavigationResponse} types | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 245512 [details]
Patch
Attachment 245512 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:115: The parameter name "frameInfo" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:122: The parameter name "frameInfo" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:153: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:271: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:329: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 6 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245529 [details]
Patch
Attachment 245529 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:115: The parameter name "frameInfo" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:122: The parameter name "frameInfo" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:153: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:271: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:329: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 6 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 245529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245529&action=review > Source/WebKit2/UIProcess/API/APIFrameInfo.h:45 > + FrameInfo(const WebKit::WebFrameProxy&); I would mark this as explicit. > Source/WebKit2/UIProcess/API/APIFrameInfo.h:47 > + ~FrameInfo() I would mark this as virtual. I'm actually not sure if you need it at all. > Source/WebKit2/UIProcess/API/APINavigationAction.h:54 > + ~NavigationAction() Same comment as the FrameInfo destructor. > Source/WebKit2/UIProcess/API/APINavigationResponse.h:52 > + ~NavigationResponse() Same comment as the FrameInfo destructor. |
Add API::{FrameInfo, NavigationAction, NavigationResponse} types