Bug 140974

Summary: REGRESSION (OS X 10.10.2): media/track/track-in-band-style.html frequently times out
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch. none

Description Alexey Proskuryakov 2015-01-27 18:33:02 PST
media/track/track-in-band-style.html has started to time out about 50% of runs on debug WebKit1 and WebKit2 after upgrading the bots from OS X 10.0 to 10.10.2.
Comment 1 Radar WebKit Bug Importer 2015-01-27 18:33:29 PST
<rdar://problem/19624943>
Comment 2 Alexey Proskuryakov 2015-01-27 18:38:15 PST
+CONSOLE MESSAGE: line 83: No text track cue with display id '-webkit-media-text-track-display' is currently visible
+FAIL: Timed out waiting for notifyDone to be called

Added a test expectation in <http://trac.webkit.org/r179237>.
Comment 3 Eric Carlson 2015-01-29 10:54:09 PST
This test plays ~1.5 seconds of a video with internal cues, seeks back to 0.3, and checks the style of the cue that should be visible at that time. When it fails, there isn't a visible cue because the media engine hasn't delivered a cue for that time, I believe because of startup latency.
Comment 4 Eric Carlson 2015-01-29 10:57:46 PST
Created attachment 245632 [details]
Proposed patch.

Introduce a brief pause between receiving the 'seemed' event and checking caption style to allow for media engine latency.
Comment 5 Eric Carlson 2015-01-29 11:11:41 PST
Created attachment 245634 [details]
Updated patch.
Comment 6 Brent Fulgham 2015-01-29 15:03:40 PST
Comment on attachment 245634 [details]
Updated patch.

r = me
Comment 7 WebKit Commit Bot 2015-01-29 16:02:54 PST
Comment on attachment 245634 [details]
Updated patch.

Clearing flags on attachment: 245634

Committed r179377: <http://trac.webkit.org/changeset/179377>
Comment 8 WebKit Commit Bot 2015-01-29 16:02:59 PST
All reviewed patches have been landed.  Closing bug.