Bug 140952

Summary: JavaScript bindings constructors should take Ref<ImplType>&&.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Andreas Kling 2015-01-27 12:57:07 PST
When constructing a JS wrapper object, there is always going to be a corresponding DOM object.
Therefore we should pass the DOM object by Ref&& rather than PassRefPtr.
Comment 1 Andreas Kling 2015-01-27 12:58:50 PST
Created attachment 245462 [details]
Comment 2 WebKit Commit Bot 2015-01-29 11:41:12 PST
Comment on attachment 245462 [details]

Clearing flags on attachment: 245462

Committed r179353: <http://trac.webkit.org/changeset/179353>
Comment 3 WebKit Commit Bot 2015-01-29 11:41:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2015-01-29 17:12:33 PST
Several WebGL tests started to flakily fail around the time of this change. Can it be the culprit?