Bug 140952

Summary: JavaScript bindings constructors should take Ref<ImplType>&&.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-01-27 12:57:07 PST
When constructing a JS wrapper object, there is always going to be a corresponding DOM object. Therefore we should pass the DOM object by Ref&& rather than PassRefPtr.
Attachments
Patch (51.94 KB, patch)
2015-01-27 12:58 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-01-27 12:58:50 PST
Created attachment 245462 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-29 11:41:12 PST
Comment on attachment 245462 [details] Patch Clearing flags on attachment: 245462 Committed r179353: <http://trac.webkit.org/changeset/179353>
WebKit Commit Bot
Comment 3 2015-01-29 11:41:16 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2015-01-29 17:12:33 PST
Several WebGL tests started to flakily fail around the time of this change. Can it be the culprit? http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Fglsl%2Ffunctions%2Fglsl-function-cos.html
Note You need to log in before you can comment on or make changes to this bug.