Bug 140939

Summary:

REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-01-27 07:06:41 PST

When I ran Tools/Scripts/configure-xcode-for-ios-development Perl emitted a warning about the subroutine named "wanted" being redefined:

Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106.

Comment 1 Daniel Bates 2015-01-27 07:08:10 PST

Created attachment 245444 [details]
Patch

Comment 2 Daniel Bates 2015-01-27 07:32:21 PST

Comment on attachment 245444 [details]
Patch

Clearing flags on attachment: 245444

Committed r179180: <http://trac.webkit.org/changeset/179180>

Comment 3 Daniel Bates 2015-01-27 07:32:24 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 David Kilzer (:ddkilzer) 2015-01-27 08:17:28 PST

Comment on attachment 245444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245444&action=review

> Tools/Scripts/webkitdirs.pm:2174
> -    sub wanted {
> +    my $wantedFunction = sub {

We should do the same thing for the wanted() function in webkitdirs.pm.