Summary: | Implement ES6 class syntax without inheritance support | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | JavaScriptCore | Assignee: | Ryosuke Niwa <rniwa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | barraclough, buildbot, commit-queue, fpizlo, ggaren, mark.lam, oliver, ossy, rniwa, ysuzuki |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 140491 | ||
Attachments: |
Description
Ryosuke Niwa
2015-01-26 19:10:29 PST
Created attachment 245406 [details]
Implements the feature
Comment on attachment 245406 [details] Implements the feature Attachment 245406 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5323382946004992 New failing tests: webgl/1.0.2/conformance/glsl/functions/glsl-function-reflect.html webgl/1.0.2/conformance/glsl/functions/glsl-function-normalize.html webgl/1.0.2/conformance/glsl/functions/glsl-function-faceforward.html js/dom/JSON-stringify.html Created attachment 245410 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 245406 [details] Implements the feature Attachment 245406 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5048201170124800 New failing tests: webgl/1.0.2/conformance/glsl/functions/glsl-function-reflect.html webgl/1.0.2/conformance/glsl/functions/glsl-function-normalize.html webgl/1.0.2/conformance/glsl/functions/glsl-function-faceforward.html js/dom/JSON-stringify.html Created attachment 245413 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 245417 [details]
Fixed the tests
Comment on attachment 245417 [details] Fixed the tests Attachment 245417 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5798757442519040 Number of test failures exceeded the failure limit. Created attachment 245421 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 245422 [details]
Second attempt to fix tests
Comment on attachment 245422 [details] Second attempt to fix tests View in context: https://bugs.webkit.org/attachment.cgi?id=245422&action=review Looks mostly OK. > Source/JavaScriptCore/parser/Nodes.h:1625 > + Identifier m_name; This is a memory leak. In the parser, we (usually) don't run destructors. You should arrange to use Identifier& instead, like other AST nodes. It would be nice if you could add a has_trivial_destructor ASSERT somewhere to catch this kind of thing in the future. Created attachment 245495 [details]
Don't leak identifiers
Comment on attachment 245495 [details]
Don't leak identifiers
r=me
Comment on attachment 245495 [details] Don't leak identifiers Clearing flags on attachment: 245495 Committed r179371: <http://trac.webkit.org/changeset/179371> All reviewed patches have been landed. Closing bug. (In reply to comment #13) > Comment on attachment 245495 [details] > Don't leak identifiers > > Clearing flags on attachment: 245495 > > Committed r179371: <http://trac.webkit.org/changeset/179371> The tests fail on the bots, please skip them for jsc-stress-tests too. (In reply to comment #15) > (In reply to comment #13) > > Comment on attachment 245495 [details] > > Don't leak identifiers > > > > Clearing flags on attachment: 245495 > > > > Committed r179371: <http://trac.webkit.org/changeset/179371> > > The tests fail on the bots, please skip them for jsc-stress-tests too. Oops, sorry about that. Skipped them in https://trac.webkit.org/r179379 |