Bug 140909

Summary:

Simple line layout: Make FlowContents an iterator class.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	none

zalan

Reported 2015-01-26 16:26:14 PST

so that createLineRuns() does not need to know about current position. This is in preparation to support <br>.

Attachments
Patch (21.40 KB, patch) 2015-01-26 16:46 PST, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (601.17 KB, application/zip) 2015-01-26 17:19 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (718.40 KB, application/zip) 2015-01-26 17:28 PST, Build Bot	no flags	Details
Patch (21.72 KB, patch) 2015-01-27 07:41 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2015-01-26 16:46:16 PST

Created attachment 245390 [details] Patch

Antti Koivisto

Comment 2 2015-01-26 16:54:50 PST

r=me, nice

Build Bot

Comment 3 2015-01-26 17:19:12 PST

Comment on attachment 245390 [details] Patch Attachment 245390 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5318298778468352 New failing tests: fast/css/font-face-zero-hash-key.html

Build Bot

Comment 4 2015-01-26 17:19:16 PST

Created attachment 245394 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-01-26 17:28:53 PST

Comment on attachment 245390 [details] Patch Attachment 245390 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6326792533049344 New failing tests: fast/css/font-face-zero-hash-key.html

Build Bot

Comment 6 2015-01-26 17:28:57 PST

Created attachment 245396 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

zalan

Comment 7 2015-01-27 07:41:24 PST

Created attachment 245446 [details] Patch

WebKit Commit Bot

Comment 8 2015-01-27 09:01:08 PST

Comment on attachment 245446 [details] Patch Clearing flags on attachment: 245446 Committed r179185: <http://trac.webkit.org/changeset/179185>

WebKit Commit Bot

Comment 9 2015-01-27 09:01:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.