Bug 140903

Summary: Modernize some constructors of the CSS JIT
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Benjamin Poulain 2015-01-26 14:41:17 PST
Modernize some constructors of the CSS JIT
Comment 1 Benjamin Poulain 2015-01-26 14:43:33 PST
Created attachment 245376 [details]
Patch
Comment 2 Darin Adler 2015-01-26 20:19:30 PST
Comment on attachment 245376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245376&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:155
> +    BacktrackingAction traversalBacktrackingAction = BacktrackingAction::NoBacktracking;

I’ve been using the { } syntax for these instead of the = syntax. I wonder if we should chose one over the other for the project as a whole.
Comment 3 Benjamin Poulain 2015-01-27 12:46:32 PST
Comment on attachment 245376 [details]
Patch

Clearing flags on attachment: 245376

Committed r179204: <http://trac.webkit.org/changeset/179204>
Comment 4 Benjamin Poulain 2015-01-27 12:46:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Benjamin Poulain 2015-01-27 12:47:22 PST
(In reply to comment #2)
> Comment on attachment 245376 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245376&action=review
> 
> > Source/WebCore/cssjit/SelectorCompiler.cpp:155
> > +    BacktrackingAction traversalBacktrackingAction = BacktrackingAction::NoBacktracking;
> 
> I’ve been using the { } syntax for these instead of the = syntax. I wonder
> if we should chose one over the other for the project as a whole.

Yep, we should.