Bug 140902

Summary: Rename Document::body() to Document::bodyOrFrameset() for clarity
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-01-26 14:09:58 PST
Rename Document::body() to Document::bodyOrFrameset() for clarity. This method does not necessarily return an HTMLBodyElement, it can also return a frameset as per the specification: http://www.w3.org/TR/html5/dom.html#dom-tree-accessors This method is often misused internally (the caller is only interested in the <body> element). I will fix these instances in a follow-up patch.
Attachments
Patch (38.79 KB, patch)
2015-01-26 14:45 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (39.60 KB, patch)
2015-01-26 15:13 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-26 14:45:31 PST
Created attachment 245377 [details] Patch
Chris Dumez
Comment 2 2015-01-26 15:13:21 PST
Created attachment 245380 [details] Patch
Andreas Kling
Comment 3 2015-01-26 15:38:38 PST
Comment on attachment 245380 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-01-26 16:26:24 PST
Comment on attachment 245380 [details] Patch Clearing flags on attachment: 245380 Committed r179157: <http://trac.webkit.org/changeset/179157>
WebKit Commit Bot
Comment 5 2015-01-26 16:26:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.