Bug 140891

Summary: Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140577, 140777    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-01-26 11:13:08 PST
Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value) to make sure the argument is not unexpectedly moved when it shouldn't (like I experienced yesterday in Bug 140577).
Attachments
Patch (3.47 KB, patch)
2015-01-26 11:15 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-26 11:15:11 PST
Created attachment 245357 [details] Patch
Chris Dumez
Comment 2 2015-01-26 11:20:07 PST
Darin, I verified that with this patch, the moving issue from yesterday is gone if I drop the const from "CSSFontFamily* fontFamily" member. Good thing I asked Anders about it today :)
WebKit Commit Bot
Comment 3 2015-01-26 12:04:40 PST
Comment on attachment 245357 [details] Patch Clearing flags on attachment: 245357 Committed r179131: <http://trac.webkit.org/changeset/179131>
WebKit Commit Bot
Comment 4 2015-01-26 12:04:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.