Bug 140891

Summary:

Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, darin, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

140577, 140777

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2015-01-26 11:13:08 PST

Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value) to make sure the argument is not unexpectedly moved when it shouldn't (like I experienced yesterday in Bug 140577).

Comment 1 Chris Dumez 2015-01-26 11:15:11 PST

Created attachment 245357 [details]
Patch

Comment 2 Chris Dumez 2015-01-26 11:20:07 PST

Darin, I verified that with this patch, the moving issue from yesterday is gone if I drop the const from "CSSFontFamily* fontFamily" member. Good thing I asked Anders about it today :)

Comment 3 WebKit Commit Bot 2015-01-26 12:04:40 PST

Comment on attachment 245357 [details]
Patch

Clearing flags on attachment: 245357

Committed r179131: <http://trac.webkit.org/changeset/179131>

Comment 4 WebKit Commit Bot 2015-01-26 12:04:46 PST

All reviewed patches have been landed.  Closing bug.