Bug 14089
| Summary: | Can't build Qt version | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Hommey <mh+webkit> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Major | ||
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=140852 | ||
Mike Hommey
Changeset 22027[1], introducing plugins loading, breaks the build because the added qwebobjectplugin_p.h[2] file includes a private header: private/qfactoryloader_p.h that is not included. I'm not sure including private headers is a good idea anyways... so it would be better, IMHO, to do whatever is possible to *not* include qwebobjectplugin_p.h at all.
1. http://trac.webkit.org/projects/webkit/changeset/22027
2. http://trac.webkit.org/projects/webkit/browser/trunk/WebKitQt/Api/qwebobjectplugin_p.h?rev=22027
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
George Staikos
Has been fixed.