Bug 140885

Summary: [cmake] Remove compiler version calculate cruft
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2015-01-26 05:34:01 PST
[cmake] Remove compiler version calculate cruft
Comment 1 Csaba Osztrogonác 2015-01-26 05:35:15 PST
Created attachment 245343 [details]
Patch

It depends on bug140884, which fixes the grammar issue of TestWithFailureCount.
Comment 2 Csaba Osztrogonác 2015-01-26 05:38:23 PST
(In reply to comment #1)
> Created attachment 245343 [details]
> Patch

This COMPILER_VERSION variable isn't used long long time ago, not to 
mention the non-dumpversion case, which is a QNX cruft introduced in http://trac.webkit.org/changeset/105014/trunk/Source/cmake/WebKitHelpers.cmake

Let's remove this cruft.

> It depends on bug140884, which fixes the grammar issue of
> TestWithFailureCount.
Ooops, this comment is a copy/paste error, please ignore it.
Comment 3 WebKit Commit Bot 2015-01-26 10:04:01 PST
Comment on attachment 245343 [details]
Patch

Clearing flags on attachment: 245343

Committed r179121: <http://trac.webkit.org/changeset/179121>
Comment 4 WebKit Commit Bot 2015-01-26 10:04:07 PST
All reviewed patches have been landed.  Closing bug.