Bug 140884

Summary: [buildbot] Fix grammar of TestWithFailureCount
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140821    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-01-26 04:24:29 PST
class TestWithFailureCount(shell.Test): failedTestsFormatString = "%d tests failed" output is always in plural, which is incorrect and should be fixed.
Attachments
Patch (6.48 KB, patch)
2015-01-26 04:29 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-01-26 04:29:03 PST
Created attachment 245340 [details] Patch
Csaba Osztrogonác
Comment 2 2015-01-26 04:30:11 PST
the idea is come from: https://bugs.webkit.org/show_bug.cgi?id=140821#c4 : "1 tests" is not good grammar. Given that one failing test is the most common failure case, I think that the error text should be nice.
WebKit Commit Bot
Comment 3 2015-01-26 04:31:03 PST
Attachment 245340 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:158: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:179: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 4 2015-01-26 09:20:24 PST
Comment on attachment 245340 [details] Patch Clearing flags on attachment: 245340 Committed r179116: <http://trac.webkit.org/changeset/179116>
Csaba Osztrogonác
Comment 5 2015-01-26 09:20:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.