Bug 140860

Summary: [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2015-01-24 19:34:16 PST
[iOS] [SVG -> OTF Converter] Flip the switch off on iOS
Attachments
Patch (31.22 KB, patch)
2015-01-24 19:36 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.79 KB, patch)
2015-01-26 08:43 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-01-24 19:36:54 PST
Created attachment 245291 [details] Patch
Myles C. Maxfield
Comment 2 2015-01-24 19:38:40 PST
<rdar://problem/19571385>
Tim Horton
Comment 3 2015-01-24 19:59:28 PST
Comment on attachment 245291 [details] Patch In the interests of minimizing this patch, why not just keep it in the xcconfig file and switch by platform (see earlier examples, like ENABLE_WEB_TIMING)?
Myles C. Maxfield
Comment 4 2015-01-24 20:00:30 PST
Because xcconfig files are ugly. (4 different places to say the same thing???)
Sam Weinig
Comment 5 2015-01-24 23:15:04 PST
Comment on attachment 245291 [details] Patch This change should be in the xcconfig file only. There is no reason to use Platform.h for this.
Myles C. Maxfield
Comment 6 2015-01-26 08:43:42 PST
Created attachment 245351 [details] Patch
WebKit Commit Bot
Comment 7 2015-01-26 10:33:33 PST
Comment on attachment 245351 [details] Patch Clearing flags on attachment: 245351 Committed r179124: <http://trac.webkit.org/changeset/179124>
WebKit Commit Bot
Comment 8 2015-01-26 10:33:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.