Summary: | [iOS] [SVG -> OTF Converter] Flip the switch off on iOS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, dino, jonlee, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2015-01-24 19:34:16 PST
Created attachment 245291 [details]
Patch
Comment on attachment 245291 [details]
Patch
In the interests of minimizing this patch, why not just keep it in the xcconfig file and switch by platform (see earlier examples, like ENABLE_WEB_TIMING)?
Because xcconfig files are ugly. (4 different places to say the same thing???) Comment on attachment 245291 [details]
Patch
This change should be in the xcconfig file only. There is no reason to use Platform.h for this.
Created attachment 245351 [details]
Patch
Comment on attachment 245351 [details] Patch Clearing flags on attachment: 245351 Committed r179124: <http://trac.webkit.org/changeset/179124> All reviewed patches have been landed. Closing bug. |