Bug 140751

Summary: [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal runtime in simctl output
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, glenn, jake.nielsen.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: iOS 8.1   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2015-01-21 17:12:48 PST
Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies with an error because it doesn't know how to parse the simctl output with respect to an Apple Internal runtime.
Attachments
Patch (7.20 KB, patch)
2015-01-21 17:23 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-01-21 17:23:21 PST
Created attachment 245102 [details] Patch I am not happy with this patch. The Simulator class and is fragile since it depends on parsing the output of the simctl tool, which may change. We should find a better way to query the state of simulator devices, runtimes, and their capabilities. One idea is to use a similiar approach as we do in webkitdirs.pm to support the scripts run-webkit-app and run-safari and read the device.plist files directly in ~/Library/Developer/CoreSimulator/Devices instead of querying simctl for the information in these files. It is a larger refactoring to implement such a change so I suggest we defer it to another patch.
David Kilzer (:ddkilzer)
Comment 2 2015-01-22 10:48:16 PST
Comment on attachment 245102 [details] Patch r=me
Daniel Bates
Comment 3 2015-01-22 10:51:50 PST
Comment on attachment 245102 [details] Patch Clearing flags on attachment: 245102 Committed r178925: <http://trac.webkit.org/changeset/178925>
Daniel Bates
Comment 4 2015-01-22 10:51:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.